Curse

It's still working for me.  Have you checkout out the question "Why isn't spell X flashing?" in the FAQ?

Quote from Myzou»

Can you explain to me the reasoning behind Heroic Leap ALWAYS flashing while Colossus Smash is up (at least as Arms)?

A. It has an 8 yard minimum range. Except for maybe 2-3 bosses, you will go outside their hit box. Running away to leap wastes time on colossus smash giving you a major DPS loss.

B. The glyph was nerfed in 5.2, and no longer doubles it's damage.

C. It hits for less than an autoattack.

It is certainly possible to use heroic leap on just about any boss while staying within melee range.  Try it on a target dummy (which has a hitbox smaller than most bosses): you can stand at the edge of melee range on one side of the dummy, leap a minimum distance over to the other side, and you are still in melee range, with a couple yards to spare.

However, I understand that it can be tricky to use well, especially w/ a smaller hitbox where you'd want to time it such that it doesn't interfere w/ your swing timer too much, so I'll make it flash at 1/2 size for the next release.  That should make it less annoying if you want to ignore it.

And just a suggestion: Any chance you could make Sunder Armor NOT flash once it's at 3 stacks if you have the Glyph of Colossus Smash active?

It should already stop flashing once it's at 3 stacks - which is working for me.  Is that broken for you?

Also: Why doesn't Skull Banner flash at all? Timing it with Colossus Smash, Bloodbath, and Recklessness makes you do crazy insane.

Skull Banner is not just a personal cooldown; it buffs the whole raid.  For that reason it should be coordinated with the whole raid, not just your own cooldowns & procs.  In general I never flash raid cooldowns in my modules (like Bloodlust or Stormlash Totem).

I put up a new version like 2 1/2 minutes ago that should fix this.  Try it out.  :)

Bitten's SpellFlash Library has been updated for 5.2 but I have not yet gotten to this module.  As it says on the lib page (sorry haven't updated descriptions here or other places yet) you no longer need to download (or update) the library. If you downgrade to the older library, it may work again?  (Haven't tried it since the patch.)

Quote from Kliamovich»

What do you think about having Cleave flash at the same time as Heroic Strike?  They cost the same amount or rage and are modified by the same talents and glyphs, e.g. Ultimatum and Glyph of Incite.  I consider which to use sitiuational based on the number of mobs I'm tanking.

I would flash Cleave if I made an AoE rotation for Prot (feel free to suggest that).

When, if ever, will execute flash?  I figgure it costs the same amount of rage as Heroic Strike and would help proc Victory Rush sooner. :)

Execute never flashes for Prot; it only uses rage for things that will help mitigation.  You say it costs the same rage as Heroic Strike - but the addon should only be flashing Heroic Strike when it is free.  If you are in a situation where you do not need to totally optimize mitigation and can help out w/ dps a bit, it makes sense to fill in in with higher damage abilities, but the addon is designed to guide you to maximum survivablity.

Target dummies are not a great way to see the tanking rotations in action.  It is not based around dps or threat - it is based around survivability.  In a general sense, more rage = more survivability, so it will use Shield Slam and Revenge as much as possible to generate rage.  But if you are at full rage (which seems very possible when simply playing with a target dummy), that would be a waste of the cooldown ... better to wait until you spend some rage and have those "cooldowns" ready to fill it back up.

Try hitting Shield Block/Barrier to spend some rage, you should see the other spells lighting up to give you back more rage.

Dps cooldowns (like Avatar) generally are not included in tanking rotations.  Simply press them as you see fit.  :)

<Edit:> By the way, have you checked out the rotation's descritpion page?

Quote from Kliamovich »

... are BigRedBrent's Spellflash modules out of date?  I was also wondering if yours and his use the same or similar code for Protection Warriors.  Thanks again. :)

I cannot tell you anything about his modules, actually.  I've never tried them.  For that reason, I would guess they are not terribly similar ... but maybe!